Consolidating old snapshot and modsnap logic by riverszhang89 · Pull Request #5803 · bloomberg/comdb2

riverszhang89 · 2026-03-11T16:17:54Z

Removes support for new-snapshot, default snapshot implementation to MODSNAP.

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_force_commit_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode
consumer_non_atomic_default_consumer_generated
tunables
reco-ddlk-sql

riverszhang89 · 2026-03-15T17:33:48Z

/plugin-branch modsnaponly

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_force_commit_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
reco-ddlk-sql

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart
silogdel
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_force_commit_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode

roborivers

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
scindex_logicalsc_generated
silogdel
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated **quarantined**
silogdel
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**

riverszhang89 · 2026-04-08T15:09:40Z

cdb2test   Apr  6 22:05:17 2026      success modsnaponly.R20260406.14

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
silogdel
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
socksql_master_swings [db unavailable at finish]
silogdel
noresetgen
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
sc_resume
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_force_commit_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode
consumer_non_atomic_default_consumer_generated **quarantined**
api_tst

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
selectv_rcode_serialretry_generated [failed with core dumped]
consumer_non_atomic_default_consumer_generated **quarantined**
api_tst
alias
sc_redo [timeout]

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated **quarantined**
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
unifiedcancel **quarantined**
api_tst
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
phys_rep_tiered_firstfile_generated
sc_resume_logicalsc_generated **quarantined**
sc_timepart_multiddl_generated
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cldeadlock
analyze **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
insert_lots [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
scindex_logicalsc_generated [failed with core dumped]
truncatesc_offline_generated [failed with core dumped] **quarantined**
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated [failed with core dumped] **quarantined**
analyze_partial_index_off_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
tunables

Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net> Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

roborivers

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**

riverszhang89 marked this pull request as draft March 11, 2026 16:18

roborivers suggested changes Mar 11, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 060d618 to 1b075f4 Compare March 15, 2026 17:33

riverszhang89 force-pushed the modsnaponly branch from 1b075f4 to 1d686d4 Compare March 15, 2026 17:35

roborivers suggested changes Mar 15, 2026

View reviewed changes

roborivers suggested changes Mar 27, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 1d686d4 to 1922ba4 Compare March 28, 2026 12:47

roborivers suggested changes Mar 28, 2026

View reviewed changes

roborivers suggested changes Mar 30, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 3da6ef2 to f969dc6 Compare March 31, 2026 22:17

roborivers suggested changes Mar 31, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from f969dc6 to 985d086 Compare April 5, 2026 16:38

roborivers suggested changes Apr 5, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 72a15f4 to 87914b6 Compare April 5, 2026 20:12

roborivers approved these changes Apr 5, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 87914b6 to 7ec39cd Compare April 5, 2026 23:49

roborivers suggested changes Apr 5, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 7ec39cd to 31fa8ad Compare April 6, 2026 00:23

roborivers suggested changes Apr 6, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 31fa8ad to a91880a Compare April 6, 2026 00:42

roborivers suggested changes Apr 6, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from a91880a to 0461387 Compare April 6, 2026 15:10

roborivers approved these changes Apr 7, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from 0461387 to d29a9c1 Compare April 8, 2026 15:09

riverszhang89 marked this pull request as ready for review April 8, 2026 15:09

roborivers approved these changes Apr 8, 2026

View reviewed changes

riverszhang89 force-pushed the modsnaponly branch from d29a9c1 to cf287f9 Compare April 10, 2026 19:01

roborivers approved these changes Apr 11, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch 2 times, most recently from 7982703 to fbe4d0e Compare April 15, 2026 18:09

roborivers approved these changes Apr 16, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch 2 times, most recently from 8bb052f to 453fd93 Compare April 16, 2026 13:33

roborivers approved these changes Apr 16, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch 2 times, most recently from c272d53 to dd2acf3 Compare April 16, 2026 21:37

roborivers approved these changes Apr 16, 2026

View reviewed changes

roborivers approved these changes Apr 17, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch from dd2acf3 to 8160cfa Compare April 17, 2026 12:34

roborivers approved these changes Apr 17, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch 2 times, most recently from e2fd9cc to 979e6f6 Compare April 20, 2026 15:08

roborivers approved these changes Apr 20, 2026

View reviewed changes

roborivers suggested changes Apr 20, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch from 979e6f6 to c18f58a Compare April 22, 2026 12:44

roborivers suggested changes Apr 22, 2026

View reviewed changes

markhannum force-pushed the modsnaponly branch 2 times, most recently from 3e4c474 to 33a20eb Compare April 22, 2026 19:44

roborivers suggested changes Apr 23, 2026

View reviewed changes

riverszhang89 added 2 commits April 23, 2026 07:35

Minimal fix for snapshot-made-default fallback to blocksql

3c90616

Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net> Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

Having only one snapshot implementation

ca5cc97

Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net> Signed-off-by: Mark Hannum <mhannum@bloomberg.net>

markhannum force-pushed the modsnaponly branch from 33a20eb to ca5cc97 Compare April 23, 2026 11:35

roborivers suggested changes Apr 23, 2026

View reviewed changes

Conversation

riverszhang89 commented Mar 11, 2026 • edited by markhannum Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

riverszhang89 commented Mar 15, 2026

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

riverszhang89 commented Apr 8, 2026

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

roborivers left a comment

Choose a reason for hiding this comment

Uh oh!

riverszhang89 commented Mar 11, 2026 •

edited by markhannum

Loading