ci(release): add Intel macOS (x86_64) DMG as a release target#748
Open
tlongwell-block wants to merge 1 commit into
Open
ci(release): add Intel macOS (x86_64) DMG as a release target#748tlongwell-block wants to merge 1 commit into
tlongwell-block wants to merge 1 commit into
Conversation
tlongwell-block
force-pushed
the
intel-mac-release
branch
from
9653e4e to
fdec13a
Compare
Adds a release-macos-x64 job that builds, codesigns, notarizes, and uploads a separate x86_64 DMG to the same versioned GitHub release, so Intel Macs get a native installer alongside Apple Silicon. - New release-macos-x64 job mirrors the arm64 release job but builds --target x86_64-apple-darwin and omits the auto-updater steps (the updater manifest stays arm64-only for now; Intel/Linux auto-update is a tracked follow-up). - bundle-sidecars.sh now reads from target/<triple>/release for cross-target builds (it previously always read target/release, which silently picked up host-arch binaries under a cross --target). - RELEASING.md updated: macOS now ships two DMGs (arm64 + Intel); corrected the stale 'ARM64 only' claims. Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
tlongwell-block
force-pushed
the
intel-mac-release
branch
from
fdec13a to
3253403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Intel macOS (
x86_64) as a release target. The release workflow now produces a separate, native Intel DMG alongside the existing Apple Silicon one, both codesigned/notarized and attached to the samev<version>GitHub release.Why
The release only built
darwin-aarch64, so Intel Macs had no native download. This ships them aSprout_<version>_x64.dmg.We chose two separate DMGs over a universal binary: I built both locally and measured — a universal DMG is 99 MB vs 49 MB for single-arch (the app is native-binary heavy; the sidecars are 20–34 MB each, so a fat binary nearly doubles the download). Two ~50 MB DMGs keep each download small.
Changes
.github/workflows/release.yml— newrelease-macos-x64job (needs: release). Builds--target x86_64-apple-darwin, codesigns + notarizes via the sameblock/apple-codesign-action, uploads the Intel DMG to the same versioned release. Mirrors the existingrelease-linuxjob's shape; the arm64releasejob is untouched.scripts/bundle-sidecars.sh— reads fromtarget/<triple>/releasefor cross-target builds. Previously it always readtarget/release, which under a cross--targetwould silently bundle host-arch binaries. No-arg/host behavior is unchanged (backward-compatible with the arm64 job).RELEASING.md— documents the two-DMG macOS setup; corrects the stale "ARM64 only" / "no notarization" claims.Scope / follow-up
darwin-aarch64-only for now (option b). Intel users get the installer but not auto-updates yet — same gap Linux has. Addingdarwin-x86_64(and Linux) entries tolatest.jsonis a tracked follow-up.Verification
x64(52 MB, purex86_64) andaarch64(49 MB, purearm64) — confirmed vialipo -archson the app binary + all 6 sidecars.bundle-sidecars.shforx86_64-apple-darwin; confirmed it pulls the correct per-arch sidecars.block/apple-codesign-action(local builds were--no-sign). Expected to be a non-event — notarytool is arch-agnostic — but it hasn't run in CI yet. And the x86 slice should be smoke-tested on real Intel hardware.