Improve release workflow. #994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/improve-release-workflow
branch
from
27bb133 to
4f11b21
Compare
myronmarston
had a problem deploying
to
rubygems.org
GitHub Actions
Failure
myronmarston
force-pushed
the
myron/fix-version-bump
branch
from
0562772 to
88d217e
Compare
myronmarston
force-pushed
the
myron/improve-release-workflow
branch
from
4f11b21 to
175c078
Compare
myronmarston
changed the title
myronmarston
force-pushed
the
myron/improve-release-workflow
branch
from
175c078 to
f22a53f
Compare
myronmarston
had a problem deploying
to
rubygems.org
GitHub Actions
Failure
myronmarston
force-pushed
the
myron/improve-release-workflow
branch
from
f22a53f to
c74feeb
Compare
myronmarston
had a problem deploying
to
rubygems.org
GitHub Actions
Failure
Three related fixes: 1. Bump the version in `runtime_metadata.yaml`. It embeds the EG version, so it must be updated during version bump. 2. Trigger CI on release PRs via workflow_dispatch. PRs created by GITHUB_TOKEN don't trigger pull_request workflows (GitHub prevents infinite loops). Now we explicitly trigger CI so release PRs get the required status check. 3. Disable commit signing so tagged commit lands in main. create-pull-request with sign-commits: true recreates commits via GitHub API with new SHAs, orphaning the tagged commit. Co-Authored-By: Claude <noreply@anthropic.com>
myronmarston
force-pushed
the
myron/improve-release-workflow
branch
from
c74feeb to
59a5849
Compare
myronmarston
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch,
lancethomps,
nicolewoch and
thomasmahoney
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three related fixes:
Bump the version in
runtime_metadata.yaml. It embeds the EG version,so it must be updated during version bump.
Trigger CI on release PRs via workflow_dispatch.
PRs created by GITHUB_TOKEN don't trigger pull_request workflows
(GitHub prevents infinite loops). Now we explicitly trigger CI
so release PRs get the required status check.
Disable commit signing so tagged commit lands in main.
create-pull-request with sign-commits: true recreates commits
via GitHub API with new SHAs, orphaning the tagged commit.
Co-Authored-By: Claude noreply@anthropic.com