generated from block/oss-project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Working goproxy implementation #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1e09053
feat: Working goproxy implementation
js-murph 497e629
fix: A bold faced lie
js-murph ff941e5
fix: configure goproxy to use our logger
alecthomas 1a287d4
Update internal/strategy/gomod_cacher.go
js-murph d61cfb4
Update internal/strategy/gomod_cacher.go
js-murph 93f43af
fix: Remove configurable TTL parameters
js-murph a4e22b6
Merge branch 'johnm/investigate-goproxy' of https://github.com/block/…
js-murph 4016d77
fix: unused import
js-murph 49fed12
fix: Remove superfluous comments
js-murph 824d568
fix: Remove unused Content-Type headers
js-murph 64c058c
fix: Linting
js-murph 56c0656
fix: Don't cache endpoints that change
js-murph 5c4030c
Merge branch 'main' into johnm/investigate-goproxy
js-murph 24da037
fix: Test assert.NoError instead of panic
js-murph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,7 @@ disk { | |
| limit-mb = 250000 | ||
| max-ttl = "8h" | ||
| } | ||
|
|
||
| gomod { | ||
| proxy = "https://proxy.golang.org" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package strategy | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "io" | ||
| "io/fs" | ||
| "strings" | ||
|
|
||
| "github.com/block/cachew/internal/cache" | ||
| ) | ||
|
|
||
| type goproxyCacher struct { | ||
| cache cache.Cache | ||
| } | ||
|
|
||
| func (g *goproxyCacher) Get(ctx context.Context, name string) (io.ReadCloser, error) { | ||
| key := cache.NewKey(name) | ||
|
|
||
| rc, _, err := g.cache.Open(ctx, key) | ||
| if err != nil { | ||
| return nil, fs.ErrNotExist | ||
| } | ||
|
|
||
| return rc, nil | ||
| } | ||
|
|
||
| func (g *goproxyCacher) Put(ctx context.Context, name string, content io.ReadSeeker) error { | ||
| if strings.HasSuffix(name, "/@v/list") || strings.HasSuffix(name, "/@latest") { | ||
| return nil | ||
| } | ||
|
|
||
| key := cache.NewKey(name) | ||
|
|
||
| wc, err := g.cache.Create(ctx, key, nil, 0) | ||
| if err != nil { | ||
| return fmt.Errorf("create cache entry: %w", err) | ||
| } | ||
| defer wc.Close() | ||
|
|
||
| if _, err := content.Seek(0, io.SeekStart); err != nil { | ||
| return fmt.Errorf("seek to start: %w", err) | ||
| } | ||
|
|
||
| if _, err := io.Copy(wc, content); err != nil { | ||
| return fmt.Errorf("write to cache: %w", err) | ||
| } | ||
|
|
||
| if err := wc.Close(); err != nil { | ||
| return fmt.Errorf("close cache entry: %w", err) | ||
| } | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sick!