-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add agent-specific rule filtering #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hiroki Osame <hiroki.osame@gmail.com>
94c7dd6 to
6a92382
Compare
|
@privatenumber thank you for submitting a PR for this! I tested it out a little (there's an example folder you can play around in and run Didn't seem to work fully as expected. I tried to allow only cursor to have a rule but it ended up getting applied to AGENTS.md We have an issue i'm not sure how to solve, several agents share AGENTS.md which is problematic if one of the rules has allowed/blocked e.g if goose has a specific rule that only applies to it, that would get added to the AGENTS.md file. I'm not sure how we can solve that, do you have any ideas? |
Signed-off-by: Hiroki Osame <hiroki.osame@gmail.com>
|
Thanks for the feedback! I pushed an update that should address both issues:
Let me know if this works for your use case or if you'd like any adjustments to the behavior. |
jonandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@privatenumber Looks good, i'm just wondering if it's better for
allowedAgents: [goose] to include it for all AGENTS.md and just give a warning instead of excluding it? Either way can work but think that would be the cleanest IMO
| pub const OPTIONAL_RULES_FILENAME: &str = "ai-rules-generated-optional.md"; | ||
| pub const AGENTS_MD_FILENAME: &str = "AGENTS.md"; | ||
| pub const AGENTS_MD_GROUP_NAME: &str = "agents-md"; | ||
| pub const AGENTS_MD_AGENTS: [&str; 7] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should infer this from the dynamic loading and check where they store their files.
Might be hard to remember to update
Summary
Testing
Closes #25