Add paging to UI #44
Merged
Add paging to UI #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangershony
reviewed
May 29, 2025
| this.apiBaseUrl + this.apiBasePath + '/api/v1/query/Angor/projects/' + angorId + '/investments' | ||
| this.apiBaseUrl + this.apiBasePath + '/api/v1/query/Angor/projects/' + angorId + '/investments' + | ||
| (from == undefined ? '' : '?offset=' + from) + | ||
| (limit == undefined ? '' : '&limit=' + limit) |
Member
There was a problem hiding this comment.
what if offset is null and limit is not null then we will get a badly formed url.
perhaps you should use the queryParams like in the method getAngorProjects
that will probably correctly append the ? and &
theDRB123
force-pushed
the
paging-on-investor-ui
branch
from
3ab6cbe to
66fe4ad
Compare
theDRB123
force-pushed
the
paging-on-investor-ui
branch
from
66fe4ad to
f171411
Compare
dangershony
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: