Fix Github Actions Workflow #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
There was a problem hiding this comment.
Pull request overview
This PR attempts to modernize the GitHub Actions workflow by upgrading the setup-go action and updating Go versions. However, there are critical issues with version specifications that will prevent the workflow from functioning correctly.
- Upgrades
actions/setup-gofrom v1 to v5 - Updates Go version testing matrix to include newer versions
- Updates minimum Go version in go.mod
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the minimum Go version directive (contains syntax error) |
| .github/workflows/tests.yml | Upgrades setup-go action and updates Go version matrix for testing (references unreleased versions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/blevesearch/scorch_segment_api/v2 | ||
|
|
||
| go 1.21 | ||
| go 1.24.0 |
There was a problem hiding this comment.
The Go version directive in go.mod should use only major.minor format (e.g., "go 1.24"), not major.minor.patch format. The ".0" patch version should be removed.
Suggested change
| go 1.24.0 | |
| go 1.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/setup-go@v1toactions/setup-go@v5go 1.24.0