Skip to content

New Total Commander Cleaner (Review wanted!)#166

Open
Tobias-B-Besemer wants to merge 18 commits intobleachbit:masterfrom
Tobias-B-Besemer:total_commander
Open

New Total Commander Cleaner (Review wanted!)#166
Tobias-B-Besemer wants to merge 18 commits intobleachbit:masterfrom
Tobias-B-Besemer:total_commander

Conversation

@Tobias-B-Besemer
Copy link
Contributor

@Tobias-B-Besemer Tobias-B-Besemer commented Feb 16, 2019

No description provided.

akaleeroy and others added 11 commits February 16, 2019 01:10
@akaleeroy @Tobias-B-Besemer
✨ Add foo_youtube cleaner
94b8bf5
@Tobias-B-Besemer
Started to do some mistakes...
9a3be9b
@Tobias-B-Besemer
Fixing a dead link
e74b59a
@Tobias-B-Besemer
Revert my mistake
e6b4f99 
This reverts commit 904bf33.
@Tobias-B-Besemer
IrfanView (bleachbit#149)
33e19ab 
Clean IrfanView thanks to Tobias-B-Besemer
@az0 @Tobias-B-Besemer
Change search from file to glob
6489105 
There are no wildcards
@Tobias-B-Besemer
LightAlloy (bleachbit#155)
6cbce5a 
Clean Light Alloy
@Tobias-B-Besemer
SMPlayer (bleachbit#148)
c01bb34 
Clean SMPlayer thanks to Tobias-B-Besemer
@Tobias-B-Besemer
Add BiglyBT
b326a15 
BiglyBT is a fork of Vuze. See: https://github.com/BiglySoftware/BiglyBT

Moved from bleachbit repository
@Tobias-B-Besemer
Merge pull request #3 from az0/master
615a3bd 
New try to make my Fork more clean
@Tobias-B-Besemer
New Total Commander Cleaner
95d073d
@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Feb 16, 2019

I wrote a new Total Commander Cleaner because I didn't saw that there is one already pending... :-/

I can Try to merge them, if I should...

Unfortunately my Cleaner isn't listed/shown in BB and I don't know why... :-/

@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Feb 16, 2019

This would be my "Final" Version of the Total Commander Cleaner...

...but I get Error Msgs...

And I think they also should be improved...

Have no clue what's this time wrong with the cleaner.

2019-02-16 21_18_26-bleachbit

@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Feb 18, 2019

OK, the cleaner is OK, it's a bug! I filled this issue: bleachbit/bleachbit#448

@az0 az0 changed the title New Total Commander Cleaner New Total Commander Cleaner (pending code bug fix to BleachBit) Mar 7, 2019
@Tobias-B-Besemer Tobias-B-Besemer mentioned this pull request Sep 10, 2019
Closed
@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Nov 30, 2019

Guess the edited name was in corelation to the encoding bug fixed in BB3...
...so I change the name back and request again for review.

@Tobias-B-Besemer Tobias-B-Besemer changed the title New Total Commander Cleaner (pending code bug fix to BleachBit) New Total Commander Cleaner (pending code bug fix to Ble Nov 30, 2019
@Tobias-B-Besemer Tobias-B-Besemer changed the title New Total Commander Cleaner (pending code bug fix to Ble New Total Commander Cleaner (Review wanted!) Nov 30, 2019
@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Nov 30, 2019 •
edited
Loading

Just FYI:
There is still one issue open related to this cleaner!
It's the wrong line breaks in INI files!
bleachbit/bleachbit#678
But this issue effect all INI cleaners - not just the Total Commander one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tobias-B-Besemer @akaleeroy @az0