-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/trunk-init #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cpritchett
commented
Nov 17, 2025
- Updated CONTRIBUTING.md to improve clarity and structure.
- Cleaned up dependabot.yml by removing unnecessary whitespace.
- Modified release-drafter.yml for consistent quotation style and formatting.
- Adjusted workflows (black.yml, codeql.yml, deploy-PROD.yml, deploy-RELEASE.yml, docker-publish.yml) for consistent quotation marks and formatting.
- Refined .pre-commit-config.yaml by removing redundant entries and ensuring proper formatting.
- Improved launch.json formatting in .vscode for better readability.
- Enhanced README.md with clearer formatting and additional spacing for improved readability.
- Refactored app.py and various GitHub app modules (azuread.py, core.py, googleworkspace.py, keycloak.py, ldap.py, okta.py, onelogin.py) for consistent import ordering and formatting.
- Updated CONTRIBUTING.md to improve clarity and structure. - Cleaned up dependabot.yml by removing unnecessary whitespace. - Modified release-drafter.yml for consistent quotation style and formatting. - Adjusted workflows (black.yml, codeql.yml, deploy-PROD.yml, deploy-RELEASE.yml, docker-publish.yml) for consistent quotation marks and formatting. - Refined .pre-commit-config.yaml by removing redundant entries and ensuring proper formatting. - Improved launch.json formatting in .vscode for better readability. - Enhanced README.md with clearer formatting and additional spacing for improved readability. - Refactored app.py and various GitHub app modules (azuread.py, core.py, googleworkspace.py, keycloak.py, ldap.py, okta.py, onelogin.py) for consistent import ordering and formatting.
Summary of ChangesHello @cpritchett, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on improving the overall code quality and consistency of the repository. It addresses various formatting issues, standardizes quotation styles in configuration files, optimizes import statements in Python modules, and enhances the readability of documentation. These changes aim to make the codebase more uniform, easier to understand, and simpler to maintain for current and future contributors. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant number of formatting and style changes across the codebase, likely from an automated tool, which improves consistency and readability. The changes include standardizing indentation, quotes, and import order in Python files, YAML files, and shell scripts. I've reviewed the changes and they look good overall. I've only found a few minor issues related to unused imports in some of the Python files, which should be removed to improve code maintainability.