-
Notifications
You must be signed in to change notification settings - Fork 0
fix(actions): replace black with trunk #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the code quality workflow by replacing Python Black with Trunk, a more comprehensive code quality tool that provides formatting, linting, and autofix capabilities across multiple languages and tools.
Key Changes:
- Introduced Trunk-based workflow with automated formatting and linting
- Added automatic commit capability for code quality fixes
- Removed legacy Black-only formatting workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/lint.yml |
New workflow that installs Trunk, runs formatting and linting checks, and optionally commits autofixes |
.github/workflows/black.yml |
Removed Black-based formatting workflow in favor of Trunk |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/lint.yml
Outdated
| - name: Install Trunk | ||
| run: | | ||
| curl -fsSL https://get.trunk.io -o- | bash | ||
| echo "$HOME/.trunk/bin" >> $GITHUB_PATH |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Trunk installation method downloads and executes a script from the internet without verification. Consider pinning to a specific version or using a verified GitHub Action from the Trunk team for better security and reproducibility. For example, you could use trunk-io/trunk-action if available, or at minimum verify the script's checksum before execution.
| - name: Install Trunk | |
| run: | | |
| curl -fsSL https://get.trunk.io -o- | bash | |
| echo "$HOME/.trunk/bin" >> $GITHUB_PATH | |
| - name: Set up Trunk | |
| uses: trunk-io/trunk-action@v1 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@cpritchett I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: cpritchett <3866278+cpritchett@users.noreply.github.com>
fix(actions): use official trunk-io actions for installation and checks
This pull request updates the code quality workflow for the repository by replacing the previous Python Black-based formatting workflow with a new Trunk-based code quality and linting workflow. The new workflow provides automated code formatting, linting, and autofix capabilities using Trunk, streamlining code quality checks in pull requests.
Workflow changes:
.github/workflows/lint.ymlto introduce a Trunk-based code quality workflow, which runs formatting, linting, and autofix steps on pull requests and pushes, and optionally commits autofixes back to the repository..github/workflows/black.yml, which previously handled code formatting using Python Black, in favor of the more comprehensive Trunk workflow.