Skip to content

Conversation

@cpritchett
Copy link

This pull request updates the code quality workflow for the repository by replacing the previous Python Black-based formatting workflow with a new Trunk-based code quality and linting workflow. The new workflow provides automated code formatting, linting, and autofix capabilities using Trunk, streamlining code quality checks in pull requests.

Workflow changes:

  • Added .github/workflows/lint.yml to introduce a Trunk-based code quality workflow, which runs formatting, linting, and autofix steps on pull requests and pushes, and optionally commits autofixes back to the repository.
  • Removed .github/workflows/black.yml, which previously handled code formatting using Python Black, in favor of the more comprehensive Trunk workflow.

@cpritchett cpritchett requested a review from Copilot November 17, 2025 08:47
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the code quality workflow by replacing Python Black with Trunk, a more comprehensive code quality tool that provides formatting, linting, and autofix capabilities across multiple languages and tools.

Key Changes:

  • Introduced Trunk-based workflow with automated formatting and linting
  • Added automatic commit capability for code quality fixes
  • Removed legacy Black-only formatting workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/lint.yml New workflow that installs Trunk, runs formatting and linting checks, and optionally commits autofixes
.github/workflows/black.yml Removed Black-based formatting workflow in favor of Trunk

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 20 to 23
- name: Install Trunk
run: |
curl -fsSL https://get.trunk.io -o- | bash
echo "$HOME/.trunk/bin" >> $GITHUB_PATH
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Trunk installation method downloads and executes a script from the internet without verification. Consider pinning to a specific version or using a verified GitHub Action from the Trunk team for better security and reproducibility. For example, you could use trunk-io/trunk-action if available, or at minimum verify the script's checksum before execution.

Suggested change
- name: Install Trunk
run: |
curl -fsSL https://get.trunk.io -o- | bash
echo "$HOME/.trunk/bin" >> $GITHUB_PATH
- name: Set up Trunk
uses: trunk-io/trunk-action@v1

Copilot uses AI. Check for mistakes.
cpritchett and others added 2 commits November 17, 2025 02:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cpritchett
Copy link
Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link

Copilot AI commented Nov 17, 2025

@cpritchett I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits November 17, 2025 08:57
Co-authored-by: cpritchett <3866278+cpritchett@users.noreply.github.com>
fix(actions): use official trunk-io actions for installation and checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants