-
-
Notifications
You must be signed in to change notification settings - Fork 10
Feature: Intel HEX loader #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…an Intel HEX file
…om a file into segment data
…oad addresses to segment data slices
…ed the FirmwareStorage interface
Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
========================================
- Coverage 6.11% 5.84% -0.28%
========================================
Files 29 29
Lines 3237 3390 +153
Branches 3237 3390 +153
========================================
Hits 198 198
- Misses 3019 3172 +153
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging
As a sidenote, even though we prefer if users use the elf files to update the firmware we will need the support for these formats down the road for other things, so it is definitely not a wasted effort. :D
|
Agreed, especially with what's planned for the tool's future wrt becoming a more capable BMP-specific replacement for BMDA! |
In this PR we address the Intel HEX support that has till now just been a stub that bombs the tool out. This completes the trifecta of formats the tool understands (raw .bin, ELF, ihex) and can use as a data source for the firmware.
This is mostly just for completeness sake as the build system is capable of producing a .hex of the firmware. The preference is still for users to have the tool work with ELF files as they're the most information-complete and robust mechanism available.