Skip to content

Conversation

@dragonmux
Copy link
Member

In this PR we address the Intel HEX support that has till now just been a stub that bombs the tool out. This completes the trifecta of formats the tool understands (raw .bin, ELF, ihex) and can use as a data source for the firmware.

This is mostly just for completeness sake as the build system is capable of producing a .hex of the firmware. The preference is still for users to have the tool work with ELF files as they're the most information-complete and robust mechanism available.

@dragonmux dragonmux added this to the v1.1 release milestone Dec 18, 2025
@dragonmux dragonmux requested a review from esden December 18, 2025 05:22
@dragonmux dragonmux added the enhancement New feature or request label Dec 18, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 18, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  src/firmware_type.rs  95% smaller
  src/firmware_file/mod.rs  81% smaller
  src/firmware_file/elf.rs  81% smaller
  src/firmware_file/ihex.rs  2% smaller

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.84%. Comparing base (a952aba) to head (46ea365).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/firmware_file/ihex.rs 0.00% 161 Missing ⚠️
src/firmware_file/elf.rs 0.00% 13 Missing ⚠️
src/firmware_type.rs 0.00% 6 Missing ⚠️
src/firmware_file/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #70      +/-   ##
========================================
- Coverage   6.11%   5.84%   -0.28%     
========================================
  Files         29      29              
  Lines       3237    3390     +153     
  Branches    3237    3390     +153     
========================================
  Hits         198     198              
- Misses      3019    3172     +153     
  Partials      20      20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

As a sidenote, even though we prefer if users use the elf files to update the firmware we will need the support for these formats down the road for other things, so it is definitely not a wasted effort. :D

@esden esden merged commit 46ea365 into main Dec 20, 2025
8 of 11 checks passed
@dragonmux dragonmux deleted the feature/ihex-loader branch December 20, 2025 02:57
@dragonmux
Copy link
Member Author

Agreed, especially with what's planned for the tool's future wrt becoming a more capable BMP-specific replacement for BMDA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants