Skip to content

Conversation

@xobs
Copy link
Contributor

@xobs xobs commented Nov 6, 2025

Detailed description

Use PRIu32 for formatting the uint32_t icepick_idcode value. This is required when building for targets where %u doesn't mean uint32_t.

Your checklist for this pull request

Use PRIu32 for formatting the uint32_t `icepick_idcode` value.

Signed-off-by: Sean Cross <sean@xobs.io>
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes - our bad! Thanks for noticing and fixing this, LGTM - so merging. Thank you for the contribution!

@dragonmux dragonmux merged commit a0db591 into blackmagic-debug:main Nov 6, 2025
39 checks passed
@dragonmux dragonmux added this to the v2.1 release milestone Nov 6, 2025
@dragonmux dragonmux added the Bug Confirmed bug label Nov 6, 2025
@xobs xobs deleted the icepick-debug-formatting branch November 6, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants