Fix: LPC support and code style #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix various issues with how it works, including clobbering RAM during scan
…e LPC11xx, LPC15xx and LPC546xx support
…present the information required across all LPC devices
… ID magic numbers
…es proper constants too
…s memory map registrations
… device ID address, and their Flash and SRAM sizes proper constants too
…e ID location LPC11xx series memory map registrations
…es proper constants too
…Flash variation memory map registrations
…es memory map registrations
dragonmux
added
Enhancement
|
Hi, there might have been small misdirect, i dont have LPC chips, mostly using the WCH riscv chips. |
Member
Author
|
Per #634 you did have LPC11U6x parts at least 5 years ago, so we were hoping to cash in on you perhaps still having them to be able to poke it; no worries if you don't. |
|
ok, that was something i was working with at that time, i dont have access to the board(s) any longer unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we overhaul the LPC part support, fixing code style issues, documentation issues, nomenclature issues, and upgrading the IAP support to be more generic across all the parts.
This also includes sorting out the LPC11xx/LPC8xx support (which turns out to also be LPC13xx support) and fixing the giant magic number soup within.
We would greatly appreciate if @mean00 would please test the LPC11U67 support in particular as we overhauled the way those parts are being supported and detected and the TRM was not consistent on whether the Device ID register on that part is at SYSCON +0x3f4 or +0x3f8.
This PR winds up adding support for several more parts in the LPC11xx families too.
Your checklist for this pull request
We are keenly aware that we do not have a significant number of the parts impacted by this PR to test and that what we do have needs to be carefully checked. This will happen over the next several days as and when we can manage it.
Closing issues