fix: prevent data loss during V2 to V1 settings migration #18
+166
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Settings migration from V2 to V1 was silently dropping unmapped properties when their parent container had some mapped properties. For example, if
general.themewas mapped butgeneral.newFeatureFlagwas not, the entiregeneralkey would be marked as consumed, losingnewFeatureFlag.Solution
lodash.unsetChanges
settings.ts: Refactored migration to use path-based trackingsettings.test.ts: Added test validating unmapped property preservationTesting
New test validates that:
preferredEditor,folderTrust)newFeatureFlag,blackbox.apiKey)fixes #13