Skip to content

fix: increase SIGKILL timeout from 200ms to 5s for graceful shutdown #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akramcodez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: increase SIGKILL timeout from 200ms to 5s for graceful shutdown #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/services/shellExecutionService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ describe('ShellExecutionService child_process fallback', () => {
);

// Now, advance time past the timeout
await vi.advanceTimersByTimeAsync(250);
await vi.advanceTimersByTimeAsync(5050);

// Check the second kill signal
expect(mockProcessKill).toHaveBeenCalledWith(
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/services/shellExecutionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { getCachedEncodingForBuffer } from '../utils/systemEncoding.js';
import { isBinary } from '../utils/textUtils.js';
const { Terminal } = pkg;

const SIGKILL_TIMEOUT_MS = 200;
const SIGKILL_TIMEOUT_MS = 5000;

// @ts-expect-error getFullText is not a public API.
const getFullText = (terminal: Terminal) => {
Expand Down