Skip to content

PM-36416 - Implement master password reprompt seeding#7598

Open
theMickster wants to merge 2 commits intomainfrom
server-PM-36416-seeder-implementing-reprompt
Open

PM-36416 - Implement master password reprompt seeding#7598
theMickster wants to merge 2 commits intomainfrom
server-PM-36416-seeder-implementing-reprompt

Conversation

@theMickster
Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-36416 - SeederDB: Allow item creation with Master Password reprompt flag enabled

📔 Objective

Ensure that we are able to set the master password re-prompt flag via the Seeder.
We are now able to set it via the SeederAPI and via presets via the SeederUtility.

@theMickster theMickster added the ai-review Request a Claude code review label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the seeder changes that thread CipherRepromptType through CipherSeed, CipherComposer, the per-type cipher factories, and the generated/personal cipher steps, plus the new repromptEveryNthCipher preset knob and the Reprompt flag added to the UserCard/UserIdentity/UserSecureNote scenes. Also re-reviewed the CipherBulkRow projection in BulkCommitter that works around LinqToDB dropping CipherRepromptType? on the EF model. The end-to-end wiring is consistent (factories set Reprompt on the CipherViewDto so it survives the encryption round-trip; new scenes follow the existing UserLoginCipherScene pattern of overriding cipher.Reprompt after creation), and the JSON schema and presets manifest update line up with the code.

The previously flagged documentation/code mismatch in presets.md (the "SQL Server only — non-SQL-Server providers log a warning and skip the column" sentence that did not exist in the code) has been resolved in commit aa035a29b "Fix docs" — the docs no longer claim provider-specific skip behavior, and the CipherBulkRow projection works uniformly across all EF providers.

Code Review Details

No findings.

Comment thread util/Seeder/Seeds/docs/presets.md Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.73%. Comparing base (baf933d) to head (aa035a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7598      +/-   ##
==========================================
- Coverage   59.83%   59.73%   -0.11%     
==========================================
  Files        2103     2106       +3     
  Lines       92788    92680     -108     
  Branches     8266     8246      -20     
==========================================
- Hits        55522    55364     -158     
- Misses      35296    35352      +56     
+ Partials     1970     1964       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theMickster theMickster marked this pull request as ready for review May 8, 2026 13:31
@theMickster
Copy link
Copy Markdown
Contributor Author

Howdy @ifernandezdiaz 👋🏼
The work for master password re-prompt is ready for your review. I wasn't able to tag you on the PR for some reason, though.

@theMickster theMickster requested a review from MGibson1 May 8, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant