[PM-25690] Create UpdateUserResetPasswordEnrollment command

[r-tome]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25690

📔 Objective

Extract the method from OrganizationService into its own command.

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This refactor extracts UpdateUserResetPasswordEnrollmentAsync from OrganizationService into a dedicated UpdateUserResetPasswordEnrollmentCommand following the CQS pattern. The implementation logic is preserved verbatim, both controller call sites are migrated, the method is removed from IOrganizationService, and the now-unused IPolicyQuery dependency is correctly dropped from OrganizationService. Marking resetPasswordKey as nullable on the new interface documents the previously-implicit withdraw-via-null contract.

Code Review Details

No findings. Coverage of validation branches (orgUser missing, calling user mismatch, org missing or UseResetPassword=false, policy disabled, auto-enroll + withdrawal) is thorough in UpdateUserResetPasswordEnrollmentCommandTests, and the new integration tests exercise the enroll and withdraw happy paths end-to-end. The DI registration sits next to sibling organization-user commands using the same AddScoped style as the rest of AddOrganizationUserCommands. The previous reviewer's concern about conditional logic in tests has been addressed via shared helper methods and clearer test names.

[codecov]

Codecov Report

❌ Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.77%. Comparing base (55e06e3) to head (2148a4f).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...llment/UpdateUserResetPasswordEnrollmentCommand.cs	95.12%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7594      +/-   ##
==========================================
+ Coverage   59.76%   59.77%   +0.01%     
==========================================
  Files        2103     2110       +7     
  Lines       92738    92786      +48     
  Branches     8262     8250      -12     
==========================================
+ Hits        55426    55464      +38     
- Misses      35354    35355       +1     
- Partials     1958     1967       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JimmyVo16]

Reviewing this will be my top priority today.

[JimmyVo16]

Not necessarily a blocker, but I find that conditional statements like this in tests make them harder to read and can lead to potential bugs in the test code. Can we break this out into separate tests with helper methods for the shared logic?

[r-tome]

Refactored those tests and also renamed some to be clearer

[JimmyVo16]

Just one comment about the test code, but overall approved.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud