Skip to content

Conversation

@Patrick-Pimentel-Bitwarden
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-28877

๐Ÿ“” Objective

  1. Following the conclusion in the jira ticket thread, removed all references to logging being set to true even in dev environment.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

โ€ฆreferences to logging being set to true even in dev environment.
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as ready for review January 22, 2026 21:46
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 56.05%. Comparing base (415821f) to head (636ca8a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6885      +/-   ##
==========================================
- Coverage   56.06%   56.05%   -0.01%     
==========================================
  Files        1966     1966              
  Lines       86898    86886      -12     
  Branches     7737     7735       -2     
==========================================
- Hits        48719    48705      -14     
- Misses      36377    36382       +5     
+ Partials     1802     1799       -3     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants