Skip to content

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Jan 22, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31133

📔 Objective

Add desktop-migration-milestone-4 flag

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton changed the title Add desktop-migration-milestone-4 flag [PM-31133] Add desktop-migration-milestone-4 flag Jan 22, 2026
@Hinton Hinton requested a review from willmartian January 22, 2026 14:23
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.00%. Comparing base (75a8570) to head (6c52c00).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6881   +/-   ##
=======================================
  Coverage   56.00%   56.00%           
=======================================
  Files        1966     1966           
  Lines       86875    86875           
  Branches     7737     7737           
=======================================
  Hits        48650    48650           
  Misses      36426    36426           
  Partials     1799     1799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton merged commit 46a4c09 into main Jan 26, 2026
66 of 68 checks passed
@Hinton Hinton deleted the desktop-m4 branch January 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants