[PM-29955] User reset password key can be empty string during key rotation

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29955

📔 Objective

User reset password key can be empty string. In such state, a key rotation fails with error All existing reset password keys must be included in the rotation., due to a discrepancy between how request is build in client's and how it's validated in server.

If an organization is enrolled into reset password (but not the automatic enrolment for new members), then user enrols and un-enrols from the reset password account recovery, the reset password key is set to "" empty string. https://github.com/bitwarden/clients/blob/44bdaf71b33c54172f5f2d9dca1d265c6739cbc9/apps/web/src/app/vault/individual-vault/vault-filter/components/organization-options.component.ts#L250
Note, this behaviour changed with bitwarden/clients#13889 and have been around for almost 1 year. I suspect this was accidental due to @ts-strict-ignore removal in the file.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – f8752cab-be46-4191-bbec-ad92110ca642

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.08%. Comparing base (2a45880) to head (dc739ae).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6871   +/-   ##
=======================================
  Coverage   56.08%   56.08%           
=======================================
  Files        1968     1968           
  Lines       86974    86974           
  Branches     7748     7748           
=======================================
  Hits        48783    48783           
  Misses      36385    36385           
  Partials     1806     1806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.