feat(register): [PM-27084] Account Register Uses New Data Types - Repush #6855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed up reference to master password hash
…d more comments and fixed up some long lines.
…unts controller no longer nullish allowed.
…e thrown error messages more appropriate
…tModel.cs Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ed comments for tests.
…t additions to make sure properties that were once required are still required.
…ted tests and added comments for the future.
…ed new checks from review.
…tModel.cs Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
…d new checks for master password authentication data.
…ved invalid check.
…fled around validation checks to the request model instead of the controller.
…Added comments to clarify how these data types should be used.
…Updated docs around the validation
…Removed troublesome null safeguarding.
…Removed debug file.
…Fixed error in register finish model validation.
…ed accounts controller tests.
…essed concerns from reviewer.
…d up tests a little more.
…erted throws to validation results and updated tests.
…d more validation around the master password kdf.
…fled around validation a little. In a great place now.
…ved unused import.
…ved unused import.
…ed validation tests and ToUser no longer throws bad request.
…ressed feedback and added tests.
…epts-new-data-types
…ressed more feedback. No longer overriding the master password hash.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6855 +/- ##
==========================================
+ Coverage 56.05% 59.97% +3.92%
==========================================
Files 1966 1966
Lines 86892 87049 +157
Branches 7737 7762 +25
==========================================
+ Hits 48709 52210 +3501
+ Misses 36382 32943 -3439
- Partials 1801 1896 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (5)Checkmarx found the following issues in this Pull Request
|
…epts-new-data-types-repush
…d constant for feature flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEEDS TESTING ON FEATURE BRANCH
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27084
📔 Objective
📸 Screenshots
Screen.Recording.2025-12-11.at.5.21.28.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes