Skip to content

Conversation

@cd-bitwarden
Copy link
Contributor

…aved to the database as an invalid encrypted value.

🎟️ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/99?selectedIssue=SM-1800

📔 Objective

Do not allow attackers to send over improperly encrypted values to the server and have it be saved into the database.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…aved to the database as an invalid encrypted value.
@cd-bitwarden cd-bitwarden marked this pull request as ready for review January 15, 2026 18:53
@cd-bitwarden cd-bitwarden requested a review from a team as a code owner January 15, 2026 18:53
@cd-bitwarden cd-bitwarden requested a review from Jingo88 January 15, 2026 18:53
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf0c0b060-f9da-4e9c-908d-a92f00ac8eca

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.00%. Comparing base (c7e364a) to head (2d214d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6853      +/-   ##
==========================================
- Coverage   56.00%   56.00%   -0.01%     
==========================================
  Files        1965     1965              
  Lines       86886    86886              
  Branches     7740     7740              
==========================================
- Hits        48663    48658       -5     
- Misses      36422    36429       +7     
+ Partials     1801     1799       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants