Skip to content

Conversation

@Patrick-Pimentel-Bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30810

📔 Objective

Complimentary server work to add the deeplink to the duo generated url.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Logo
Checkmarx One – Scan Summary & Details594c6cb6-fd67-4229-a780-4695e85bc3f3

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (c7e364a) to head (26fcfef).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...dentity/TokenProviders/DuoUniversalTokenService.cs 69.64% 10 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6852      +/-   ##
==========================================
+ Coverage   56.00%   56.09%   +0.08%     
==========================================
  Files        1965     1968       +3     
  Lines       86886    86981      +95     
  Branches     7740     7756      +16     
==========================================
+ Hits        48663    48790     +127     
+ Misses      36422    36384      -38     
- Partials     1801     1807       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden changed the title feat(redirect): [PM-26578] Https Redirection for Cloud Users feat(redirect): [PM-30810] Https Redirection for Cloud Users Jan 23, 2026
… client check to only allow mobile to specify the extra property being sent to the duo api when generating the token.
…ed messaging around how specific clients will build the response as well as added tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants