Skip to content

Chore: Remove Retrofit dependency from app module#6896

Open
david-livefront wants to merge 1 commit intomainfrom
remove-retrofit-dependency
Open

Chore: Remove Retrofit dependency from app module#6896
david-livefront wants to merge 1 commit intomainfrom
remove-retrofit-dependency

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR updates the 2 spots in the app module that still reference the Retrofit library and allows us to remove that dependency from the app module completely.

@david-livefront david-livefront requested a review from a team as a code owner May 8, 2026 20:38
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:tech-debt Change Type - Tech debt labels May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.93%. Comparing base (b11884c) to head (727cf0e).

Files with missing lines Patch % Lines
.../bitwarden/data/vault/manager/CipherManagerImpl.kt 85.71% 1 Missing ⚠️
...it/bitwarden/data/vault/manager/SendManagerImpl.kt 85.71% 1 Missing ⚠️
...om/bitwarden/network/service/CiphersServiceImpl.kt 83.33% 0 Missing and 1 partial ⚠️
.../com/bitwarden/network/service/SendsServiceImpl.kt 83.33% 0 Missing and 1 partial ⚠️
.../com/bitwarden/network/util/ExceptionExtensions.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6896      +/-   ##
==========================================
- Coverage   86.14%   85.93%   -0.22%     
==========================================
  Files         894      853      -41     
  Lines       62486    60997    -1489     
  Branches     8937     8904      -33     
==========================================
- Hits        53830    52419    -1411     
+ Misses       5589     5525      -64     
+ Partials     3067     3053      -14     
Flag Coverage Δ
app-data 17.50% <42.85%> (+0.31%) ⬆️
app-ui-auth-tools 19.78% <0.00%> (-0.23%) ⬇️
app-ui-platform 15.63% <0.00%> (-0.42%) ⬇️
app-ui-vault 26.60% <0.00%> (-0.68%) ⬇️
authenticator 6.45% <0.00%> (-0.01%) ⬇️
lib-core-network-bridge 4.16% <39.28%> (+0.01%) ⬆️
lib-data-ui 1.15% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant