Cleanup organizations

[david-livefront]

🎟️ Tracking

N/A

📔 Objective

This PR cleans up usages of the Organization models.

• Test usages of organization have been simplified by adding a new createMockOrganization test helper
• The network response model for organization is no longer exposed outside of the AuthRepository.
• The name property has been updated to be nonnull and we filter out organizations with null names (This change mirrors the iOS app).

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 2493ef97-af31-4bbe-b32d-1f02ffa7b58a

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.53%. Comparing base (2e311b6) to head (c81d952).

Files with missing lines	Patch %	Lines
...twarden/data/auth/repository/AuthRepositoryImpl.kt	66.66%	0 Missing and 2 partials ⚠️
...auth/repository/util/SyncResponseJsonExtensions.kt	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6391      +/-   ##
==========================================
- Coverage   85.53%   85.53%   -0.01%     
==========================================
  Files         764      764              
  Lines       55864    55869       +5     
  Branches     8118     8120       +2     
==========================================
+ Hits        47784    47788       +4     
  Misses       5273     5273              
- Partials     2807     2808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Claude finished @david-livefront's task in 1m 53s —— View job

---

Code Review Summary

PR: #6391 - Cleanup organizations
Author: david-livefront
Reviewed by: Claude (automated review)
Review Type: Re-review after rebase

---

Re-Review Confirmation

Commits were rebased on 2026-01-23 (originally authored 2026-01-21). Code content is unchanged from the initial review.

Previous approval stands - no new issues identified.

---

Overview

This PR refactors organization model usage across the codebase with three main objectives:

1. Confine network response models (SyncResponseJson.Profile.Organization) to the AuthRepository layer
2. Simplify test code by introducing a createMockOrganization test helper
3. Make the name property non-nullable, filtering out organizations with null names (mirroring iOS)

Changes Analyzed

Category	Files	Lines
Production Code	4	+32/-21
Test Code	27	+292/-516
Total	31	+324/-537

Findings

No critical, important, or blocking issues found.

Key Observations

• Architecture: Good encapsulation improvement - network models no longer exposed outside repository layer
• Null Safety: Organization.name changed from String? to String with filtering via mapNotNull - aligns with iOS behavior
• Property Additions: shouldUseEvents correctly added and mapped
• Rename: type to role in Organization model improves clarity
• Test Simplification: New createMockOrganization helper reduces ~200 lines of test boilerplate

Test Coverage

• Codecov reports 83.33% patch coverage
• All CI checks passing
• Note: No explicit test for null name filtering in toOrganizations(), though behavior is straightforward

Verdict

✅ APPROVED - Well-structured refactoring that improves code organization and reduces test complexity. No security, correctness, or architectural concerns.