baip-0004.md #21
Open
baip-0004.md #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
previously approved these changes
Feb 28, 2020
Member
|
The commit history is a bit messy. I think it's better to not have the unrelated changes in the history. If don't know how to rebase or force-push, perhaps create a new branch and make the necessary changes only, then create a new pull request. |
shulthz
force-pushed
the
master
branch
2 times, most recently
from
462c2e0 to
0af0d4e
Compare
abitmore
previously approved these changes
Feb 29, 2020
Member
abitmore
left a comment
abitmore
left a comment
There was a problem hiding this comment.
I got the spirit.
Approved for progress, regardless of potential typo, grammar errors and document structure issues.
Author
|
This baip is not perfect, but i think it is better than baip2. Still need to improve and advice in the future. Hope we will find the perfect way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.