Add support for Intel Gaudi/HPU backend #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsshaik1
changed the title
Contributor
|
@matthewdouglas @jiqing-feng Please help review this PR. We are working on documentation and unit-tests and plan to add those in separate follow-up PRs. Thanks. |
jiqing-feng
reviewed
May 29, 2025
| # self.persistent_buffers = [] # TODO consider as way to save quant state | ||
| self.compute_dtype = compute_dtype | ||
| self.compute_type_is_set = False | ||
| self.compute_type_is_set = False if compute_dtype is None else True |
Contributor
There was a problem hiding this comment.
This change seems not related to hpu, did you met any block issues?
Contributor
There was a problem hiding this comment.
@jiqing-feng Please check description in this PR #1623 . Issue which gets fixed with this change is described there.
rsshaik1
force-pushed
the
Gaudi_support
branch
2 times, most recently
from
9fb71c1 to
068f0e1
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
matthewdouglas
previously approved these changes
Jun 4, 2025
Member
matthewdouglas
left a comment
matthewdouglas
left a comment
There was a problem hiding this comment.
LGTM, just a couple small nits! Thanks!
updates the assertion message Co-authored-by: Matthew Douglas <38992547+matthewdouglas@users.noreply.github.com>
Co-authored-by: Matthew Douglas <38992547+matthewdouglas@users.noreply.github.com>
Fix lint issue
matthewdouglas
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the support of bitsandbytes for HPU (Intel Gaudi) devices.
These changes add support for single and double NF4 quantization/dequantization using Intel Gaudi hardware.