Skip to content

Refactor uniqueness check in Bitrix24PartnerRepository test contract#488

Merged
mesilov merged 1 commit into
v3-devfrom
feature/468-refactor-partner-repository-contract
May 22, 2026
Merged

Refactor uniqueness check in Bitrix24PartnerRepository test contract#488
mesilov merged 1 commit into
v3-devfrom
feature/468-refactor-partner-repository-contract

Conversation

@mesilov
Copy link
Copy Markdown
Collaborator

@mesilov mesilov commented May 22, 2026

Q A
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #468
License MIT

Refactors the Bitrix24PartnerRepositoryInterface contract so save() stays a persistence operation and no longer requires repository implementations to perform an application-level duplicate bitrix24PartnerNumber check.

Changes included:

  • removed testSaveWithTwoBitrix24PartnerNumber() from the repository contract test
  • removed the duplicate-number preflight from the in-memory repository test implementation
  • removed the @throws InvalidArgumentException contract annotation from save()
  • updated CHANGELOG.md

Test plan

  • make oa-schema-build — passed
  • make test-file path=tests/Unit/Application/Contracts/Bitrix24Partners/Repository — passed
  • make lint-cs-fixer — passed
  • make lint-rector — passed
  • make lint-phpstan — passed
  • make lint-deptrac — passed
  • make test-unit — passed

Closes #468

🤖 Generated with Claude Code

@mesilov mesilov added this to the 3.2.0 milestone May 22, 2026
@mesilov mesilov self-assigned this May 22, 2026
@mesilov mesilov merged commit 9c09f8b into v3-dev May 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant