Add IM Disk file operations#487
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6072dd989
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'FILE_ID' => $fileId, | ||
| 'UPLOAD_ID' => $uploadId, | ||
| 'MESSAGE' => $message, | ||
| 'SILENT_MODE' => $silentMode === null ? null : ($silentMode ? 'Y' : 'N'), |
There was a problem hiding this comment.
The silentMode flag is currently encoded as true => 'Y' and false => 'N', but SILENT_MODE='Y' means notifications are sent while 'N' suppresses them. This makes commitFile(..., silentMode: true) do the opposite of what the argument name implies, so callers trying to send files silently will still trigger notifications in production chats.
Useful? React with 👍 / 👎.
1 participant
Refs #482
Closes #482