Add scope Booking wrappers#476

Draft

fatestr1ngs wants to merge 1 commit into

bitrix24:v3-devfrom

fatestr1ngs:feature/473-add-booking-scope-v3

fatestr1ngs commented May 20, 2026

Q	A
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #473
License	MIT

This PR adds support for the Booking scope in the PHP SDK.

Added the Booking scope builder and typed services for booking, waitlist, resource, resource type, resource slots, client type, booking client, booking external data, waitlist client, and waitlist external data methods.
Added typed result DTOs for Booking entities and operation results.
Added integration coverage for CRUD flows and dedicated annotation validation tests for Booking result items.
Wired the new Booking tests into the PHPUnit testsuite and Makefile target.
Updated the Booking client type contract to match the live API response shape returned by the portal.

Example usage:

$builder = ServiceBuilderFactory::createServiceBuilderFromWebhook($webhookUrl);
$bookingScope = $builder->getBookingScope();

$resourceTypeId = $bookingScope->resourceType()->add([
    'code' => 'room',
    'name' => 'Room',
])->getId();

$resourceId = $bookingScope->resource()->add([
    'typeId' => $resourceTypeId,
    'name' => 'Room A',
])->getId();

$bookingId = $bookingScope->booking()->add([
    'name' => 'Consultation',
    'resourceIds' => [$resourceId],
    'datePeriod' => [
        'from' => ['timestamp' => time() + 3600, 'timezone' => 'Europe/Berlin'],
        'to' => ['timestamp' => time() + 5400, 'timezone' => 'Europe/Berlin'],
    ],
])->getId();

$booking = $bookingScope->booking()->get($bookingId);

Quality-gate checklist

make lint-cs-fixer
make lint-phpstan
make lint-rector
make test-unit
make test-integration-scope-booking
docker-compose run --rm php-cli vendor/bin/phpstan analyse tests/Integration/Services/Booking

Closes #473

fatestr1ngs mentioned this pull request

Add scope Booking wrappers #475

Draft

11 tasks

mesilov requested changes

View reviewed changes

Collaborator

mesilov left a comment

please

update branch from v3-dev
resolve comments

src/Services/Booking/Booking/Result/AddedBookingResult.php Outdated

+              /**
+               * This file is part of the bitrix24-php-sdk package.
+               *
+               * © Maksim Mesilov <mesilov.maxim@gmail.com>

Collaborator

mesilov May 25, 2026

Please add your full name and contacts

src/Services/Booking/Booking/Result/BookingItemResult.php Outdated

+               * @property-read array<string, mixed>|null $datePeriod
+               * @property-read array<int, int>|null $resourceIds
+               */
+              class BookingItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

in 3.2.0 we added https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37 with automatic type casting based on phpdocs annotations

please fix
class BookingItemResult extends AbstractItem

to
class BookingItemResult extends AbstractAnnotatedItem

src/Services/Booking/BookingClient/Result/BookingClientItemResult.php Outdated

+               * @property-read int|null $id
+               * @property-read array<string, string>|null $type
+               */
+              class BookingClientItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/BookingExternalData/Result/BookingExternalDataItemResult.php Outdated

+               * @property-read string|null $moduleId
+               * @property-read string|null $value
+               */
+              class BookingExternalDataItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/ClientType/Result/ClientTypeItemResult.php Outdated

+               * @property-read string|null $code
+               * @property-read string|null $module
+               */
+              class ClientTypeItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/ResourceType/Result/ResourceTypeItemResult.php Outdated

+               * @property-read string|null $templateTypeFeedback
+               * @property-read string|null $templateTypeReminder
+               */
+              class ResourceTypeItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/Waitlist/Result/WaitlistItemResult.php Outdated

+               * @property-read int|null $id
+               * @property-read string|null $note
+               */
+              class WaitlistItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/WaitlistClient/Result/WaitlistClientItemResult.php Outdated

+               * @property-read int|null $id
+               * @property-read array<string, string>|null $type
+               */
+              class WaitlistClientItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

src/Services/Booking/WaitlistExternalData/Result/WaitlistExternalDataItemResult.php Outdated

+               * @property-read string|null $moduleId
+               * @property-read string|null $value
+               */
+              class WaitlistExternalDataItemResult extends AbstractItem

Collaborator

mesilov May 25, 2026

change to https://github.com/bitrix24/b24phpsdk/blob/v3/src/Core/Result/AbstractAnnotatedItem.php#L22C16-L22C37

CHANGELOG.md


		### Added

		- Added `Services\Booking\BookingServiceBuilder` with Booking scope wrappers and integration coverage for `booking.v1.clienttype.`, `booking.v1.resourceType.`, `booking.v1.resource.`, `booking.v1.resource.slots.`, `booking.v1.waitlist.`, `booking.v1.waitlist.client.`, `booking.v1.waitlist.externalData.`, `booking.v1.booking.`, `booking.v1.booking.client.`, and `booking.v1.booking.externalData.` methods.

Collaborator

mesilov May 25, 2026

move to 3.3.0 planned release

mesilov added this to the 3.3.0 milestone

mesilov linked an issue

that may be closed by this pull request

[Feature in SDK]: Add Booking scope wrappers and integration tests #473

Open

9 tasks

mesilov added the enhancement in SDK label


          Add scope Booking wrappers

c497f17

fatestr1ngs force-pushed the feature/473-add-booking-scope-v3 branch from 23c325c to c497f17 Compare

May 26, 2026 15:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement in SDK