uglify-js@2.8.23 breaks build 🚨 #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
uglify-js just published its new version 2.8.23.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As uglify-js is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
The new version differs by 460 commits .
5dfda6ev2.8.23d08c772Merge pull request #1871 from alexlamsl/v2.8.2390ed544fix test for #1865 (#1873)d8106b6fix label-related bugs (#1835)dda4eb9backport test scripts7305ba0fixunsafeonevaluateofreduce_vars(#1870)2c21dc5fixunusedon for-in statements (#1843)d0faa47fixunusedon labeled for-loop (#1831)6ad823dfixreduce_varswithin try-block (#1818)43ad4e9fix variable substitution (#1816)04b8964v2.8.22d6fbc36fix LHS cases for NaN & friends (#1804)9a97884enhancetest/ufuzz.js(#1803)0479ff0fix a couple of bugs inglobal_defs(#1802)cf72fe5fixdeletecorner cases (#1799)There are 250 commits in total. See the full diff.