Skip to content

CreateAccount: Fix - Use crypto.randomBytes for salt generation #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmgustavo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CreateAccount: Fix - Use crypto.randomBytes for salt generation #2175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/utils/password.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Pbkdf2 from 'pbkdf2';
import crypto from 'crypto';

const WEAK_BASE_WORDS = [
'password',
Expand Down Expand Up @@ -118,14 +119,7 @@ export const isLowEntropy = (value: string) => {
};

export const generateSalt = () => {
const salt = Pbkdf2.pbkdf2Sync(
Math.random().toString(),
Math.random().toString(),
Math.floor(Math.random() * 30),
47,
).toString('hex');

return salt;
return crypto.randomBytes(47).toString('hex');
};

export const hashPassword = (password: string) => {
Expand Down
Loading