docs: add code style guidelines based on PR #44 review #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new sections covering: - React patterns (mobx-react-lite, observer structure, page.tsx patterns) - MobX conventions (action.bound, makeObservable generics) - Dependency injection (prefer createClient() at usage site) - Routing conventions (nested routes over hyphens) - Forms/UX (password confirmation, required fields) - TypeScript (don't export internal types) These guidelines address patterns that required manual fixes in the password reset feature implementation. Closes #55 Co-authored-by: bitnimble <bitnimble@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new sections to AGENTS.md covering code style patterns that required manual fixes in the password reset feature (PR #44):
mobx-react-lite, prefer simple observer patterns, inline components in page.tsxaction.boundoverrunInAction(), propermakeObservablegenerics for private methodscreateClient()at usage site rather than DI/password/reset) over hyphens (/reset-password)required={true}, appropriate redirectsCloses #55
Generated with Claude Code