Fixed Possible division through 0#108
Open
hackepeter101 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Guards the FPS calculation in the 14-bit VGA demo against a division-by-zero when millis() returns 0, addressing issue #107.
Changes:
- Caches
millis()into a localunsigned long t. - Only performs the
(f++ * 1000) / tdivision whent > 0; otherwise resets the frame counter.
Comments suppressed due to low confidence (1)
examples/VGADemo14Bit/VGADemo14Bit.ino:46
- When
t == 0(the only momentmillis()returns 0, which is essentially just at boot), this branch prints the "fps: " label without any following number, leaving the display in an inconsistent state. Consider printing a placeholder (e.g.0) in the else branch so the output always has the same structure.
else{
f = 0; //starting FPS calculation again from frame 0
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
calculations are similar to VGA3DEngine.ino now
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#107