Add new Icon parameters to BitTimeline (#12100)#12101
Add new Icon parameters to BitTimeline (#12100)#12101msynk wants to merge 1 commit intobitfoundation:developfrom
Conversation
WalkthroughThis pull request adds external icon support to the BitTimeline component. A new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Lists/Timeline/BitTimelineDemo.razor.cs (1)
462-470:⚠️ Potential issue | 🟡 MinorPre-existing duplicate
IsEnabledentry in NameSelectors documentation.
IsEnabledappears twice in the NameSelectors parameters list (first at lines 417–425, then again at lines 462–470). While not introduced by this PR, it's worth cleaning up since you're already editing this metadata block.Proposed fix: remove the duplicate entry
new() { Name = "Reversed", Type = "BitNameSelectorPair<TItem, string?>", DefaultValue = "new(nameof(BitTimelineItem.Reversed))", Description = "Reversed field name and selector of the custom input class.", Href = "#name-selector-pair", LinkType = LinkType.Link, }, - new() - { - Name = "IsEnabled", - Type = "BitNameSelectorPair<TItem, bool>", - DefaultValue = "new(nameof(BitTimelineItem.IsEnabled))", - Description = "IsEnabled field name and selector of the custom input class.", - Href = "#name-selector-pair", - LinkType = LinkType.Link, - }, new() { Name = "SecondaryContent",
closes #12100
Summary by CodeRabbit
New Features
Documentation