-
Notifications
You must be signed in to change notification settings - Fork 1
fix: skip Claude Code Review on dependabot PRs #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip Claude Code Review on dependabot PRs #228
Conversation
Bumps [sinon](https://github.com/sinonjs/sinon) and [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon). These dependencies needed to be updated together. Updates `sinon` from 19.0.5 to 21.0.1 - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v19.0.5...v21.0.1) Updates `@types/sinon` from 17.0.4 to 21.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon) --- updated-dependencies: - dependency-name: sinon dependency-version: 21.0.1 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/sinon" dependency-version: 21.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
The Claude Code Review workflow was failing when triggered by dependabot PRs because dependabot is not in the allowed_bots list. This adds a condition to skip the workflow for dependabot PRs since dependency updates don't typically need code review. Fixes error: "Workflow initiated by non-human actor: dependabot (type: Bot)" Reference: https://github.com/bitflight-devops/github-action-jira-transition-manager/actions/runs/21342884692/job/61425127293#step:3:1 Co-authored-by: Jamie-BitFlight <25075504+Jamie-BitFlight@users.noreply.github.com>
7bc421a to
1e33386
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
|
Rebase please. @copilot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the Claude Code Review workflow to prevent failures on dependabot PRs by adding a conditional check to skip the review job when the PR author is dependabot. The PR also includes updates to the sinon testing library and its type definitions.
Changes:
- Added conditional to skip Claude Code Review workflow for dependabot PRs
- Removed placeholder comment demonstrating PR author filtering
- Updated sinon from v19.0.2 to v21.0.1 and @types/sinon from v17.0.3 to v21.0.0
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/claude-code-review.yml | Added conditional check to skip workflow execution for dependabot PRs and removed commented placeholder examples |
| package.json | Updated sinon and @types/sinon to latest major versions (v21) |
| yarn.lock | Lockfile updates reflecting sinon v21 upgrade, including removal of nise dependency (now embedded in sinon) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Done! Merged latest updates from base branch in commit ccf7cb5. The branch now includes:
Note: Used merge instead of rebase since force push is not available in this environment. |
|
There's still merge conflicts |
Fix Claude Code Review workflow failure on dependabot PRs
Problem
The Claude Code Review workflow is failing when triggered by dependabot PRs with the error:
Reference: https://github.com/bitflight-devops/github-action-jira-transition-manager/actions/runs/21342884692/job/61425127293#step:3:1
Solution
Added a condition to skip the Claude Code Review workflow for dependabot PRs since dependency updates don't need code review.
Changes Made
if: github.event.pull_request.user.login != 'dependabot[bot]'to theclaude-reviewjobChecklist
Security Summary
No security vulnerabilities were found in this change. The change only adds a conditional check to skip workflow execution for dependabot PRs.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.