Skip to content

Implement Lfu events: attempt 2 #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bitfaster wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement Lfu events: attempt 2 #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions BitFaster.Caching.UnitTests/Lfu/ConcurrentLfuSoakTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Threading.Tasks;
using BitFaster.Caching.Buffers;
using BitFaster.Caching.Lfu;
using BitFaster.Caching.Lru;
using BitFaster.Caching.Scheduler;
using FluentAssertions;
using Xunit;
Expand Down Expand Up @@ -387,15 +388,16 @@ private async Task RunIntegrityCheckAsync(ConcurrentLfu<int, string> lfu, int it

private static void RunIntegrityCheck<K, V>(ConcurrentLfu<K, V> cache, ITestOutputHelper output)
{
new ConcurrentLfuIntegrityChecker<K, V, AccessOrderNode<K, V>, AccessOrderPolicy<K, V>>(cache.Core).Validate(output);
new ConcurrentLfuIntegrityChecker<K, V, AccessOrderNode<K, V>, AccessOrderPolicy<K, V>, TelemetryPolicy<K, V>>(cache.Core).Validate(output);
}
}

internal class ConcurrentLfuIntegrityChecker<K, V, N, P>
internal class ConcurrentLfuIntegrityChecker<K, V, N, P, T>
where N : LfuNode<K, V>
where P : struct, INodePolicy<K, V, N>
where T : struct, ITelemetryPolicy<K, V>
{
private readonly ConcurrentLfuCore<K, V, N, P> cache;
private readonly ConcurrentLfuCore<K, V, N, P, T> cache;

private readonly LfuNodeList<K, V> windowLru;
private readonly LfuNodeList<K, V> probationLru;
Expand All @@ -404,14 +406,14 @@ internal class ConcurrentLfuIntegrityChecker<K, V, N, P>
private readonly StripedMpscBuffer<N> readBuffer;
private readonly MpscBoundedBuffer<N> writeBuffer;

private static FieldInfo windowLruField = typeof(ConcurrentLfuCore<K, V, N, P>).GetField("windowLru", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo probationLruField = typeof(ConcurrentLfuCore<K, V, N, P>).GetField("probationLru", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo protectedLruField = typeof(ConcurrentLfuCore<K, V, N, P>).GetField("protectedLru", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo windowLruField = typeof(ConcurrentLfuCore<K, V, N, P, T>).GetField("windowLru", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo probationLruField = typeof(ConcurrentLfuCore<K, V, N, P, T>).GetField("probationLru", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo protectedLruField = typeof(ConcurrentLfuCore<K, V, N, P, T>).GetField("protectedLru", BindingFlags.NonPublic | BindingFlags.Instance);

private static FieldInfo readBufferField = typeof(ConcurrentLfuCore<K, V, N, P>).GetField("readBuffer", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo writeBufferField = typeof(ConcurrentLfuCore<K, V, N, P>).GetField("writeBuffer", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo readBufferField = typeof(ConcurrentLfuCore<K, V, N, P, T>).GetField("readBuffer", BindingFlags.NonPublic | BindingFlags.Instance);
private static FieldInfo writeBufferField = typeof(ConcurrentLfuCore<K, V, N, P, T>).GetField("writeBuffer", BindingFlags.NonPublic | BindingFlags.Instance);

public ConcurrentLfuIntegrityChecker(ConcurrentLfuCore<K, V, N, P> cache)
public ConcurrentLfuIntegrityChecker(ConcurrentLfuCore<K, V, N, P, T> cache)
{
this.cache = cache;

Expand Down
Loading
Loading