Fix ActiveRecord 5 compatibility #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwelschen
approved these changes
Jun 14, 2022
matiasgarcia
requested review from
fwelschen
and removed request for
mdallago and
werner
fwelschen
approved these changes
Jun 14, 2022
fwelschen
left a comment
fwelschen
left a comment
There was a problem hiding this comment.
@matiasgarcia te lo apruebo porque entiendo que ya esta en prod. De ultima despues fijate con infosec el tema de la key del build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries such as:
Break because the PredicateQueryBuilder expects
arel_tablemethod to be defined.This intends to fix that at least for this scenario.
Has #13 branch in it.