-
Notifications
You must be signed in to change notification settings - Fork 67
chore(api)!: remove BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs
#157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1872024 to
dbbe555
Compare
Pull Request Test Coverage Report for Build 20796560586Details
💛 - Coveralls |
BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txsBlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK dbbe555
oleonardolima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK eccf30d
I'm also wondering on how disruptive it'll be on downstream, see VM's comment, though it'll be in a major release.
|
I don't think this is a very disruptive API break, especially since the response type is just plain wrong right now. |
Closes #142.
Closes #146.
Closes #148.
Closes #150.
This PR:
BlockSummaryand usesBlockInfoforget_blocks, asBlockSummaryfails to capture the full response,PrevOut, which is identical toVout,scripthash_txstoget_scripthash_txs, to maintain the method naming convention.Amountfor all value/fee fields and removedTx::fee(),u64in favor ofWeightonTxand removedTx::weight().