Skip to content

ci(msrv)!: bump rust MSRV to 1.75.0 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oleonardolima wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci(msrv)!: bump rust MSRV to 1.75.0 #154

oleonardolima wants to merge 2 commits into from
+15 −57

Conversation

@oleonardolima
Copy link
Collaborator

@oleonardolima oleonardolima commented Jan 4, 2026

fixes #141

  • ci: update the MSRV job to use new 1.75.0 MSRV.
  • chore(clippy): update the .clippy.toml to 1.75.0 MSRV.
  • chore(docs): update the MSRV references to new 1.75.0.

@oleonardolima oleonardolima self-assigned this Jan 4, 2026
@oleonardolima oleonardolima added documentation Improvements or additions to documentation ci Continuous Integration issues summit Rust bitcoin summit labels Jan 4, 2026
@coveralls
Copy link

coveralls commented Jan 4, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20723037262

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.654%
Totals Coverage Status
Change from base Build 20722132454: 0.0%
Covered Lines: 1387
Relevant Lines: 1530
💛 - Coveralls

@oleonardolima oleonardolima mentioned this pull request Jan 5, 2026
Open
8 tasks
@oleonardolima oleonardolima force-pushed the chore/bump-msrv-to-1.75.0 branch 2 times, most recently from 592c5df to 8aa4ddd Compare January 5, 2026 02:53
@oleonardolima oleonardolima moved this to In Progress in BDK Chain Jan 5, 2026
@oleonardolima oleonardolima changed the title wip(ci(msrv)!): bump rust MSRV to 1.75.0 ci(msrv)!: bump rust MSRV to 1.75.0 Jan 5, 2026
@oleonardolima oleonardolima marked this pull request as ready for review January 5, 2026 02:58
@ValuedMammal
Copy link
Contributor

ValuedMammal commented Jan 5, 2026

Side note the CI badge in the README seems broken.

@luisschwab
Copy link
Member

luisschwab commented Jan 5, 2026

@oleonardolima this is the correct link for the CI badge

https://github.com/bitcoindevkit/rust-esplora-client/actions/workflows/cont_integration.yml/badge.svg

@oleonardolima
ci(msrv)!: bump rust MSRV to 1.75.0
b7c6fcc 
- ci: update the MSRV job to use new 1.75.0 MSRV.
- chore(clippy): update the `.clippy.toml` to 1.75.0 MSRV.
- chore(docs): update the MSRV references to new 1.75.0.
@oleonardolima
fix(docs): update CI badge
c76e89c
@oleonardolima oleonardolima force-pushed the chore/bump-msrv-to-1.75.0 branch from 8aa4ddd to c76e89c Compare January 5, 2026 17:08
@oleonardolima
Copy link
Collaborator Author

oleonardolima commented Jan 5, 2026

Side note the CI badge in the README seems broken.

Yes, I just noticed it had been broken for a while; it's fixed now.

luisschwab
luisschwab approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c76e89c

@oleonardolima
Copy link
Collaborator Author

oleonardolima commented Jan 20, 2026

As the v0.12.2 is now release, we can move forward with this.
Any other comments for this PR ? cc @luisschwab @ValuedMammal

@luisschwab
Copy link
Member

luisschwab commented Jan 20, 2026

LGTM

ValuedMammal
ValuedMammal approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c76e89c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@notmandatory notmandatory Awaiting requested review from notmandatory

+1 more reviewer

@luisschwab luisschwab luisschwab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oleonardolima oleonardolima

Labels

ci Continuous Integration issues documentation Improvements or additions to documentation summit Rust bitcoin summit

Projects

BDK Chain
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore(deps): bump MSRV to 1.75.0

4 participants

@oleonardolima @coveralls @ValuedMammal @luisschwab