fix(wallet): categorize self-transfers to external addresses as trusted_pending#431
Open
Dmenec wants to merge 2 commits intobitcoindevkit:masterfrom
Open
fix(wallet): categorize self-transfers to external addresses as trusted_pending#431Dmenec wants to merge 2 commits intobitcoindevkit:masterfrom
Dmenec wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
…ed_pending Removes previous balance functionality. Now checks every outpoint owned by the wallet and searches for trusted transactions.
…pending Add tests to verify correct balance categorization for trusted/untrusted pending transactions. Covers: - owned inputs to external output - external inputs to own output - transitive trust through a chain of unconfirmed tx
Dmenec
changed the title
Dmenec
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 80.04% 80.16% +0.12%
==========================================
Files 24 24
Lines 5336 5365 +29
Branches 242 247 +5
==========================================
+ Hits 4271 4301 +30
+ Misses 987 986 -1
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
Description
Unconfirmed transactions spending owned UTXOs to external addresses were
being incorrectly categorized as
untrusted_pending. This should not happensince all inputs are controlled by the wallet.
Notes to the reviewers
The
balancefunction iterates over all transactions in the graph and marksa transaction as trusted if all its inputs spend from owned outpoints or from
already-trusted transactions. This process repeats until no new trusted
transactions are found, in order to handle chains of unconfirmed transactions
transitively.
Checklists
All Submissions:
just pbefore pushingBugfixes: