fix(wallet): allow fee bump without opt-in RBF signaling#430
Open
alienx5499 wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(wallet): allow fee bump without opt-in RBF signaling#430alienx5499 wants to merge 1 commit intobitcoindevkit:masterfrom
alienx5499 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
9ee74f9 to
db7feac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 24 24
Lines 5336 5326 -10
Branches 242 241 -1
=======================================
- Hits 4271 4263 -8
+ Misses 987 985 -2
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #65.
Wallet::build_fee_bumppreviously refused to build a replacement when no input signaled opt-in RBF (nSequence≤0xFFFFFFFD). That guard is removed so the wallet can construct a fee-bump transaction even if the original did not opt in. Whether a replacement is accepted is a mempool / relay policy concern (e.g. default full-RBF in recent Bitcoin Core), not something this API can enforce by requiring a specificnSequenceon the prior tx.Also removes
BuildFeeBumpError::IrreplaceableTransaction, since that path is no longer reachable.Notes to the reviewers
BuildFeeBumpError::IrreplaceableTransactionis removed (breaking public enum). If you prefer a deprecation cycle for the variant only, say so and we can adjust.tests/build_fee_bump.rs— the old test expected failure for non–opt-in-RBF; it now asserts a successful fee bump with a higher fee rate.Changelog notice
fix(wallet): allow build_fee_bump without opt-in RBF on the original tx; remove IrreplaceableTransaction (#65)Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: