chore: Update rust edition to 2024 in Cargo.toml#425
Draft
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Draft
chore: Update rust edition to 2024 in Cargo.toml#425ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
This is to reduce noise related to formatting when we change the rust edition to 2024.
Removed explicit `ref` binding modifiers, as otherwise rustc complains with "cannot explicitly borrow within an implicitly borrowing pattern." Refer to https://doc.rust-lang.org/reference/patterns.html#binding-modes for details.
Removed style_edition from rustfmt.toml and ran cargo +nightly fmt.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 80.04% 80.01% -0.03%
==========================================
Files 24 24
Lines 5336 5338 +2
Branches 242 242
==========================================
Hits 4271 4271
- Misses 987 989 +2
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
WIP: Updates the rust edition in
Cargo.tomlto2024.Changelog notice
Checklists
All Submissions:
just pbefore pushing