feat: add start_height support to FilterIter#2205
Open
kafeelraza wants to merge 1 commit into
Open
Conversation
Author
|
Hi! I'd like to work on this issue. This PR adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
start_heightsupport tobitcoind_rpc::bip158::FilterIter::new.This allows filter scanning to recover from deep reorgs by resuming from a configured starting height when no common ancestor is found above that height.
Notes to the reviewers
This PR:
start_heightparameter toFilterIterCloses #2126
Changelog notice
Added
start_heightsupport tobitcoind_rpc::bip158::FilterIter::newto improve deep reorg recovery behavior.Checklists
All Submissions:
New Features: