Skip to content

Improve unknown coin selection algorithm error message#2125

Open
yashithac618 wants to merge 1 commit intobitcoindevkit:masterfrom
yashithac618:improve-coin-selection-error
Open

Improve unknown coin selection algorithm error message#2125
yashithac618 wants to merge 1 commit intobitcoindevkit:masterfrom
yashithac618:improve-coin-selection-error

Conversation

@yashithac618
Copy link

Description

Improve the error message returned when an unknown coin selection algorithm is provided.

Previously, the error message only displayed:

unknown coin selection algorithm '{unknown}'

This change updates the message to clearly list the supported algorithms:

unknown coin selection algorithm ''. Supported algorithms: largest-first, s

Notes to the reviewers

This change only modifies the error message in the FromStr implementation of CoinSelectionAlgo.
No logic or behavior has been changed.

Changelog notice

Improved CLI error message for invalid coin selection algorithm input.

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant