Improve unknown coin selection algorithm error message#2125
Open
yashithac618 wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Improve unknown coin selection algorithm error message#2125yashithac618 wants to merge 1 commit intobitcoindevkit:masterfrom
yashithac618 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the error message returned when an unknown coin selection algorithm is provided.
Previously, the error message only displayed:
unknown coin selection algorithm '{unknown}'
This change updates the message to clearly list the supported algorithms:
unknown coin selection algorithm ''. Supported algorithms: largest-first, s
Notes to the reviewers
This change only modifies the error message in the FromStr implementation of CoinSelectionAlgo.
No logic or behavior has been changed.
Changelog notice
Improved CLI error message for invalid coin selection algorithm input.
Checklists
All Submissions:
New Features:
Bugfixes: