feat: add bip353 payment instructions support #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BIP353 payment instructions support. The issue related to this PR can be found at bitcoindevkit/bdk_wallet#13.
Changes done:
bip353to conditionally enable the supportresolve_dns_recipient(hrn, amount, network), this will resolve and validate the payment against what the resolution returned using a default resolver. The call to this function will return aPaymentcontainingscriptBuf,amount, anddnssec_proof(which can be added to PSBT)resolve_dns_recipient_with_resolver(resolver, hrn, amount, network)this will do the same as the previous function but this time using the user provided resolver.TODO
ParseErrorinto an internal error type?resolve_dns_recipient_with_resolverQuestions
amountparameter asOptionso that would mean the user is just ready to pay what the resolution returns, instead of him inputting a wrong amount. What do you think?The functions added here are standalone. I'm happy to get guidance on how they could fit together with that is already implemented here