Skip to content

test: refresh BIP-352 test vectors to v1.1.1#62

Merged
nymius merged 1 commit into
bitcoindevkit:masterfrom
macgyver13:intermediate_sum_vector
May 21, 2026
Merged

test: refresh BIP-352 test vectors to v1.1.1#62
nymius merged 1 commit into
bitcoindevkit:masterfrom
macgyver13:intermediate_sum_vector

Conversation

@macgyver13
Copy link
Copy Markdown
Contributor

Description

Refresh BIP-352 test vectors to match version 1.1.1

  • Add tests 26 & 27 to send.rs and receive.rs.
  • Modify serialization to parse the updated sending.given.recipients map and maintain receiving.expected.addresses string format.

Notes to the reviewers

cargo t --test functional_tests bip352_vectors

All tests pass - 3 are ignored for this PR

test bip352_vectors::send::input_keys_intermediate_sum_is_zero_but_final_sum_is_non_zero ... ignored, currently fails due to intermediate sum being zero
test bip352_vectors::send::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented
test bip352_vectors::receive::maximum_per_group_recipient_limit_k_max_is_exceeded ... ignored, limit k-max not implemented

Resolving ignored tests will be handled in future PRs.

Checklists

All Submissions:

Add tests 26 & 27 to send.rs and receive.rs.
Modify serialization to parse the updated sending.given.recipients map and maintain receiving.expected.addresses string format
Copy link
Copy Markdown
Collaborator

@nymius nymius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bcac039

@nymius nymius merged commit 71ebdef into bitcoindevkit:master May 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants