Skip to content

fix: scan-rpc ignores wallet birthday #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nymius merged 2 commits into from
May 19, 2026
Merged

fix: scan-rpc ignores wallet birthday #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1366db7
fix(cliv2): scan-rpc ignores wallet birthday
GuiSchet May 18, 2026
d815fe6
fix(cli2): log start point at scan-rpc begin
GuiSchet May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cli/v2/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,18 @@ async fn main() -> anyhow::Result<()> {
}
Commands::ScanRpc { rpc_args } => {
let rpc_client = rpc_args.new_client()?;
let start_height = if wallet.birthday.height <= wallet.chain().tip().height() {
wallet.chain().tip().height()
} else {
wallet.birthday.height
};

tracing::info!("Synchronizing from block height {}", start_height);

let mut emitter = Emitter::new(
&rpc_client,
wallet.chain().tip(),
0,
start_height,
NO_EXPECTED_MEMPOOL_TXIDS,
);

Expand Down