fix: normalize ChainPosition ffi byte accounting#47
Draft
reez wants to merge 2 commits intobitcoindevkit:mainfrom
Draft
fix: normalize ChainPosition ffi byte accounting#47reez wants to merge 2 commits intobitcoindevkit:mainfrom
reez wants to merge 2 commits intobitcoindevkit:mainfrom
Conversation
Collaborator
Author
|
cc @OpenOne2925 |
Collaborator
Author
|
I’d prefer to fix this upstream in uniffi-dart, but this bdk-dart branch patch is a temporary workaround. Affected users can pin this branch/commit in pubspec.yaml, run flutter pub get, then fully rebuild/restart the app. |
Collaborator
Author
|
Note: CI failure here is expected this PR applies a local patch in generated Dart bindings, but CI regenerates bindings in \scripts/generate_bindings.sh, which overwrites the local fix with current upstream uniffi-dart output... the new regression test then fails against the regenerated code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re #46 here's some bdk-dart code changes to fix the wallet.transactions() crashing with UniFfi::UnexpectedEnumCase by normalizing ChainPosition FFI read/write byte accounting (relative offsets) and adding regression tests for non-zero buffer offsets.
this would be a stop gap because I believe the root cause is in uniffi-dart, but just wanted to put this code here in the meantime as I worked through the issue