Set up a new test infrastructure with bdk_testenv#267
Draft
j-kon wants to merge 1 commit intobitcoindevkit:masterfrom
Draft
Set up a new test infrastructure with bdk_testenv#267j-kon wants to merge 1 commit intobitcoindevkit:masterfrom
j-kon wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets up a new integration test infrastructure for
bdk-cliusingbdk_testenv.It replaces the dead shell-based integration test setup with a working direct-handler-based harness and adds a first funded-wallet flow test to prove the new path end to end.
What changed
bdk_testenvas a dev-dependencytests/integration.rsWhy
The previous integration test setup was commented out and relied on an outdated shell-based approach. This PR establishes a minimal working foundation for direct handler-based integration testing, which matches the direction discussed in #120.
This is PR 1 of the work around #120. The OP_RETURN follow-up has already been prepared locally on top of this branch and will be opened as a separate PR after this one lands, to keep review focused and avoid restacking the PR 1 changes.
Validation
cargo fmt --all --checkBITCOIND_EXE=/usr/local/bin/bitcoind cargo clippy --all-features --all-targets -- -D warningscargo test --all-features --test integrationcargo test --no-runcargo test --no-default-features --no-runRefs #120.
cc @tvpeter @va-an